fixed doc param inside Query Builder #2775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Jul 9, 2017
| @@ -409,7 +409,7 @@ public function getMaxResults() | |||
| * 'groupBy', 'having' and 'orderBy'. | |||
| * | |||
| * @param string $sqlPartName | |||
| * @param string $sqlPart | |||
| * @param mixed $sqlPart | |||
There was a problem hiding this comment.
In some part of the code for example in line 530 of the same file is passed as an array not as a string right?
There was a problem hiding this comment.
That's because it's upcast (line 423)
There was a problem hiding this comment.
Yes I have seen but I thought that you can call this function with a string or with an array so I thought that mixed type is better than string inside documentation.
If It's better string I understand but there are two ways for me to call this function for that parameter
There was a problem hiding this comment.
@AlessandroMinoccheri use string|string[] or whatever matches then :-)
|
Obsolete as of #3836. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a parameter documentation from string to mixed because it can be a string or an array